Re: [jts-dev] LineDissolver improvement?

[Jim Hughes <jnh5y@xxxxxxxx>]

Hi Caroline,

Yes!  Submitting a PR sounds like a great way to chat through your changes.  Generally, Martin has been pretty thoughtful about which methods are public and private; hopefully there'll be a good way to compromise.

Some info about contributing to JTS is here: https://github.com/locationtech/jts/blob/master/CONTRIBUTING.md.  (The info about the CLA is a little out of data, Eclipse is now using ECA (http://www.eclipse.org/legal/ECA.php).)

Cheers,

Jim

On 04/26/2017 01:49 PM, Caroline Kettlestrings wrote:

Hi, I'm working on a project that needs a topological description of a collection of geometries. The LineDissolver class almost does what I need, but it simply returns the lines that make up the topology, and there's no way that I can see to recreate the original geometries out of those lines. I've modified the LineDissolver class so that the dissolve method takes a map from ID to geometry, and returns a map from LineString to set of IDs which indicates which of the input geometries each line is a part of.

Unfortunately the many non-public classes and fields make it impossible to simply extend the necessary classes, so I've had to edit the JTS code itself in order to accomplish this. I'd like to submit a PR to get these changes merged in. Is there interest in this? It seems like it could be broadly useful.

Thanks,

Caroline Kettlestrings

_______________________________________________
jts-dev mailing list
jts-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/jts-dev