Re: [geogig-dev] jsr305 [geogig]

[Jody Garnett <jgarnett@xxxxxxxxxxxxxxxx>]

Yeah making our custom annotation may be a good idea.

I also do not mind if we use the one from the JDT compiler - we would need to sort out *where* they are available in jar form.

Looking into the details you can configure the JDT compiler with the specific annotations to use: http://help.eclipse.org/juno/topic/org.eclipse.jdt.doc.user/reference/preferences/java/compiler/ref-preferences-errors-warnings.htm#null_annotation_names

About the pull requests - sorry I have not been paying close attention to this project. If you have your eclipse paperwork in order there should be no problem merging in the changes. As I understand it we need several pull requests / patches before being in position to nominate a developer for commit access.

On Wed, Jun 17, 2015 at 12:06 PM, <Schmidt.Sebastian2@xxxxxx> wrote:

Hi,

as far as I understand these annotations add some valuable metadata about when some
parameters might be null and then you need to check before dereferencing in order to
avoid NullPointerExceptions.

 From a perspective of maintaining code I think it is a good idea to keep that information.

I'd suggest (and do indeed volunteer) to roll our own Annotations for Nullable and NotNull
and so cut out the JSR305 dependency. So as a maintainer you'd know that you need to check
for null before accessing.  That shouldn't be much work for some good hints to any who will
be accessing and extending geogig in the future.

Eclipse's JDT compiler can do some null analysis as well based on (custum) anntoations,
I'll check that, too. But even if we do not use static analysis tools, to a human reader this
is too valuable to just throw it away.

Just my 2 cents :-)

BTW: what is the current status of our pull requests concerning Documentation
(https://github.com/locationtech/geogig/pull/16,
https://github.com/locationtech/geogig/pull/15) and -ff-only/-non-ff Merges?
(https://github.com/locationtech/geogig/pull/13)
Is there anything we can improve to get them merged into master?

Kind regards,
Sebastian

_______________________________________________
geogig-dev mailing list
geogig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
http://www.locationtech.org/mailman/listinfo/geogig-dev

--

--
Jody Garnett
Technical Lead | Boundless
jgarnett@xxxxxxxxxxxxxxxx
877-673-6436
@jodygarnett