[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [geogig-dev] jsr305 [geogig]
|
Hi,
as far as I understand these annotations add some valuable metadata about when some
parameters might be null and then you need to check before dereferencing in order to
avoid NullPointerExceptions.
From a perspective of maintaining code I think it is a good idea to keep that information.
I'd suggest (and do indeed volunteer) to roll our own Annotations for Nullable and NotNull
and so cut out the JSR305 dependency. So as a maintainer you'd know that you need to check
for null before accessing. That shouldn't be much work for some good hints to any who will
be accessing and extending geogig in the future.
Eclipse's JDT compiler can do some null analysis as well based on (custum) anntoations,
I'll check that, too. But even if we do not use static analysis tools, to a human reader this
is too valuable to just throw it away.
Just my 2 cents :-)
BTW: what is the current status of our pull requests concerning Documentation
(https://github.com/locationtech/geogig/pull/16,
https://github.com/locationtech/geogig/pull/15) and -ff-only/-non-ff Merges?
(https://github.com/locationtech/geogig/pull/13)
Is there anything we can improve to get them merged into master?
Kind regards,
Sebastian
