Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [geogig-dev] Cannot build GeoGig since commit n°e6170356c7d3d7136d202a5fb30fe39a1ae84141
Or no, exists && (directory || parentExists) is stupid, if a file exists its parent necessarily exists.

Is not parentExists the problem here? Since you check if the CREATE option is present before, in GeoGigDataStoreFactory->canProcess?

2015-09-17 14:44 GMT+11:00 Dimitri Justeau <dimitri.justeau@xxxxxxxxx>:
So, I took a bit of time to dig more into the code:

The failing test is:

params = ImmutableMap.of(REPOSITORY.key,
         (Serializable) (workingDir.getName() + "/testCanProcess"));
assertFalse(factory.canProcess(params));

It seems like the method public boolean canHandle(URI repoURI) of DefaultRepositoryInitializer returns true while false is expected.

When I run the test, I have:

exists = false
directory = false
parentExists = true

Which seems normal to me, the file workingDir.getName() + "/testCanProcess" does not exist, is not a directory, but the parent is the working dir so it exists.

The return of the method:

return (exists && directory) || parentExists
 
Is then true.

Am I getting something wrong here? I was asking myself if then return should not be something like exists && (directory || parentExists) ?

Cheers,

Dimitri.

2015-09-16 18:52 GMT+11:00 Dimitri Justeau <dimitri.justeau@xxxxxxxxx>:
Yes, very strange.

I'm up to date with the last commit (b4f24f507afec15916ed823c1401da3ee8f918af -> "Check partialId in ObjectDatabase.lookUp(String partialId) is at least 8 chars long.").

I also tried to build on a fresh ubuntu 14.04 VM, but it ends up with the exact same fail... Also openjdk7, IcedTea 2.5.6, the same as yours. I tried to build with maven single threaded, using "mvn -T 1 clean install", but it seems it went parallel even though, and also failed. I'll try to test another environment, maybe another machine, and to make maven build single threaded for real, and let you know!

Cheers,

Dimitri.

2015-09-16 1:54 GMT+11:00 Gabriel Roldan <groldan@xxxxxxxxxxxxxxxx>:
That's strange. It just built fine for me with openjdk7

master!geogig/src/parent *> java -version
java version "1.7.0_79"
OpenJDK Runtime Environment (IcedTea 2.5.6) (7u79-2.5.6-0ubuntu1.15.04.1)
OpenJDK 64-Bit Server VM (build 24.79-b02, mixed mode)


But wait, you're probably behind commit f7f1b942403eecb8c373140921d8f7b73c2ee2ef
which fixes just that issue when maven runs tests in parallel. So just make sure your repo is up to date with locationtech's upstream?

Cheers,
Gabriel


On Mon, Sep 14, 2015 at 8:28 PM, Dimitri Justeau <dimitri.justeau@xxxxxxxxx> wrote:
Hi Gabriel,

Thank you, I'm not running under Windows but on Debian Jessie, my Java version is openjdk7 64bits. I also tried on openjdk8 64bits, I got the same result... Should I set up the sun jdk?

Also, I have a windows 7 VM set up on my system so I can also try to build on Windows and communicate you the results if it can help.

Cheers,

Dimitri.


2015-09-15 10:22 GMT+11:00 Gabriel Roldan <groldan@xxxxxxxxxxxxxxxx>:
nah, I should think before speaking. It oughta be a good habit I bet.
The patch I was talking about is for the geoserver plugin, which is hosted on another repo.

I've no clue why that test if failing for you, but just in case, what's your build environment like? (OS, java version, etc)

On Mon, Sep 14, 2015 at 8:20 PM, Gabriel Roldan <groldan@xxxxxxxxxxxxxxxx> wrote:
No worries, it was Seb Schmidt.

I'll patch it up now before I keep on forgetting and let you know so you can try. Unfortunately I don't have a Windows build box handy so you'll be my Guinea pig, ok?

Cheers,
Gabriel

On Mon, Sep 14, 2015 at 8:15 PM, Gabriel Roldan <groldan@xxxxxxxxxxxxxxxx> wrote:
Hi Dimitri,

nice to hear from you. 

This is definitely the place where to ask these kind of questions.

I seem to recall you showed me a patch for correct URI handling for Windows file system paths? I can't find it. It was you, right?

Cheers,
Gabriel


On Mon, Sep 14, 2015 at 7:12 PM, Dimitri Justeau <dimitri.justeau@xxxxxxxxx> wrote:
Hello GeoGig team!

First, let's introduce myself a bit: my name is Dimitri Justeau, I work as a developper in a small research team focused on the areas of botanics and tropical rainforest ecology in New Caledonia, a small archipelago in the South Pacific zone. We are working on a project with the environmental local authorities, and one of the goals of this project is to build a decision support system for them, based on the scientists data and environmental models.

There is a big issue on enabling a clean and collaborative data management, in order to procuce and maintain datasets on which the routines used to produce the outputs of the decision support tools will plug.

For achieving this, I'm considering the use of GeoGig, and until now I quite happy with what I'm experimenting. I am also happy to see that the project is active again.

Now, here is the problem I have:

Until the commit e6170356c7d3d7136d202a5fb30fe39a1ae84141, I was able to build the GeoGig as explained in the doc developer's section, but now, every time I try to build, It fails ending with the following error:


Results :

Failed tests:
  GeoGigDataStoreFactoryTest.testCanProcess:72->Assert.assertFalse:79->Assert.assertFalse:68->Assert.assertTrue:43->Assert.fail:92 null

Tests run: 253, Failures: 1, Errors: 0, Skipped: 0


I tried to figure out what's going wrong, but I am very new to GeoGig and could not find any clue...

Thank you for the help, and good luck with GeoGig!

Dimitri.

PS: Sorry if my english is not perfect, it is not my native language. Sorry also if it is not the right place for this kind of topics.

_______________________________________________
geogig-dev mailing list
geogig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
http://www.locationtech.org/mailman/listinfo/geogig-dev



--

Gabriel Roldán
Software Developer | Boundless
groldan@xxxxxxxxxxxxxxxx
@boundlessgeo





--

Gabriel Roldán
Software Developer | Boundless
groldan@xxxxxxxxxxxxxxxx
@boundlessgeo





--

Gabriel Roldán
Software Developer | Boundless
groldan@xxxxxxxxxxxxxxxx
@boundlessgeo



_______________________________________________
geogig-dev mailing list
geogig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
http://www.locationtech.org/mailman/listinfo/geogig-dev


_______________________________________________
geogig-dev mailing list
geogig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
http://www.locationtech.org/mailman/listinfo/geogig-dev



--

Gabriel Roldán
Software Developer | Boundless
groldan@xxxxxxxxxxxxxxxx
@boundlessgeo



_______________________________________________
geogig-dev mailing list
geogig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
http://www.locationtech.org/mailman/listinfo/geogig-dev



Back to the top